databio / bedhost

API and UI for BEDbase
http://api.bedbase.org
BSD 2-Clause "Simplified" License
2 stars 1 forks source link

Phase I polishing #11

Closed nsheff closed 4 years ago

nsheff commented 5 years ago

Phase 1 polishing

These are the things I've found that I think we should polish up to finalize phase I before moving on to phase 2.

Display cleanup

Features

Repo cleanup

Bedstat cleanup

nsheff commented 5 years ago

ok looks good. but the search result links are the same:

see how the ID differs but they all link to the same thing?

ID Link to html Raw file JSON
wgEncodeAwgTfbsBroadGm12878CtcfUniPk http://0.0.0.0:8000/regionset/?id=wgEncodeAwgTfbsBroadGm12878CtcfUniPk&format=html http://0.0.0.0:8000/regionset/?id=wgEncodeAwgTfbsBroadGm12878CtcfUniPk&format=bed http://0.0.0.0:8000/regionset/?id=wgEncodeAwgTfbsBroadGm12878CtcfUniPk&format=json
wgEncodeAwgTfbsBroadDnd41CtcfUniPk http://0.0.0.0:8000/regionset/?id=wgEncodeAwgTfbsBroadGm12878CtcfUniPk&format=html http://0.0.0.0:8000/regionset/?id=wgEncodeAwgTfbsBroadGm12878CtcfUniPk&format=bed http://0.0.0.0:8000/regionset/?id=wgEncodeAwgTfbsBroadGm12878CtcfUniPk&format=json
wgEncodeAwgTfbsBroadDnd41CtcfUniPk http://0.0.0.0:8000/regionset/?id=wgEncodeAwgTfbsBroadGm12878CtcfUniPk&format=html http://0.0.0.0:8000/regionset/?id=wgEncodeAwgTfbsBroadGm12878CtcfUniPk&format=bed http://0.0.0.0:8000/regionset/?id=wgEncodeAwgTfbsBroadGm12878CtcfUniPk&format=json
wgEncodeAwgTfbsBroadDnd41CtcfUniPk http://0.0.0.0:8000/regionset/?id=wgEncodeAwgTfbsBroadGm12878CtcfUniPk&format=html http://0.0.0.0:8000/regionset/?id=wgEncodeAwgTfbsBroadGm12878CtcfUniPk&format=bed http://0.0.0.0:8000/regionset/?id=wgEncodeAwgTfbsBroadGm12878CtcfUniPk&format=json
wgEncodeAwgTfbsBroadGm12878CtcfUniPk http://0.0.0.0:8000/regionset/?id=wgEncodeAwgTfbsBroadGm12878CtcfUniPk&format=html http://0.0.0.0:8000/regionset/?id=wgEncodeAwgTfbsBroadGm12878CtcfUniPk&format=bed http://0.0.0.0:8000/regionset/?id=wgEncodeAwgTfbsBroadGm12878CtcfUniPk&format=json
wgEncodeAwgTfbsBroadH1hescRbbp5a300109aUniPk http://0.0.0.0:8000/regionset/?id=wgEncodeAwgTfbsBroadGm12878CtcfUniPk&format=html http://0.0.0.0:8000/regionset/?id=wgEncodeAwgTfbsBroadGm12878CtcfUniPk&format=bed http://0.0.0.0:8000/regionset/?id=wgEncodeAwgTfbsBroadGm12878CtcfUniPk&format=json
wgEncodeAwgTfbsBroadHelas3CtcfUniPk http://0.0.0.0:8000/regionset/?id=wgEncodeAwgTfbsBroadGm12878CtcfUniPk&format=html http://0.0.0.0:8000/regionset/?id=wgEncodeAwgTfbsBroadGm12878CtcfUniPk&format=bed http://0.0.0.0:8000/regionset/?id=wgEncodeAwgTfbsBroadGm12878CtcfUniPk&format=json
wgEncodeAwgTfbsBroadDnd41CtcfUniPk http://0.0.0.0:8000/regionset/?id=wgEncodeAwgTfbsBroadGm12878CtcfUniPk&format=html http://0.0.0.0:8000/regionset/?id=wgEncodeAwgTfbsBroadGm12878CtcfUniPk&format=bed http://0.0.0.0:8000/regionset/?id=wgEncodeAwgTfbsBroadGm12878CtcfUniPk&format=json
wgEncodeAwgTfbsBroadH1hescEzh239875UniPk http://0.0.0.0:8000/regionset/?id=wgEncodeAwgTfbsBroadGm12878CtcfUniPk&format=html http://0.0.0.0:8000/regionset/?id=wgEncodeAwgTfbsBroadGm12878CtcfUniPk&format=bed http://0.0.0.0:8000/regionset/?id=wgEncodeAwgTfbsBroadGm12878CtcfUniPk&format=json
nsheff commented 5 years ago

~Almost everything else looks great! The only issue I found is: bedstat is currently keeping files unzipped. The specification calls for files to be stored and served in compressed format. In my hands, the "raw_bedfile" linked is still unzipped. this should be only linked if it's zipped; if it's unzipped, it should be zipped into the folder. One last tiny thing: instead of naming every link as "raw_bedfile", let's use the actual name of the bedfile or something.~

Never mind, I can take care of these things. I see what's going on with the zipping now.

nsheff commented 5 years ago

Ok I think phase I is done once you fix those links.

oddodaoddo commented 5 years ago

Ok, done. That was stupid, I looked at the search results page but I did not see the details :disappointed: