databio / bedhost

API and UI for BEDbase
http://api.bedbase.org
BSD 2-Clause "Simplified" License
2 stars 1 forks source link

I think these are creating warnings, preventing the build from completing #37

Closed nsheff closed 3 years ago

nsheff commented 4 years ago
 ./src/const.js
  Line 1:10:  'ModeComment' is defined but never used  no-unused-vars

./src/queryBuilder.jsx
  Line 4:8:  'queryBuilder' is defined but never used  no-unused-vars
nsheff commented 4 years ago

from: https://github.com/databio/bedhost/runs/1361618468?check_suite_focus=true

xuebingjie1990 commented 4 years ago

this is happening because this line: https://github.com/databio/bedhost/runs/1361618468?check_suite_focus=true#step:5:45

I resolved the listed warnings. But there are other warnings cause by the npm dependencies. (there are 2 that I'm aware of: one of them would likely resolve by the new lease in Dec. ) I don't know if they would also preventing the build from completing or not.

And I found this related issue https://github.com/facebook/create-react-app/issues/3657

nsheff commented 4 years ago

I don't know if they would also preventing the build from completing or not.

why don't you try it and see?

nsheff commented 4 years ago

looks like it succeeded this time.