Closed nsheff closed 7 months ago
pipestat's select_distinct
no longer requires table_name
as this is now an attribute of the pipestatmanager e.g. self.table_name
We've also removed pipeline_type
as this was being used to determine the table_name
.
Private_api will be deleted, because most of this endpoints were made for distance search. Now we are using qdrant, and search_router Router will be created
Just recording some ideas I've been having as I refactored bedhost
helpers.py
are raising HTTP exceptions. Instead, I think HTTP exceptions (404 errors) should only be raised by the main fastapi functions/endpoints... the helper functions should standalone. Thus, they should raise other exceptions, which should be caught and raised as 404 HTTP errors by the fastapi functions.bbc.bedset.select_distinct(table_name=BEDSET_TABLE,
, it seems theBEDSET_TABLE
information is really passed twice... once by the attributebedset
, and then again bytable_name
. instead, this should be passingpipeline_type
. (which should default to sample, and therefore probably isn't even necessary...). So, doesselect_distinct
really requiretable_name
?