databio / bulker

Manager for multi-container computing environments
https://bulker.io
BSD 2-Clause "Simplified" License
24 stars 2 forks source link

NameError: name 'create_folder' is not defined #26

Closed stolarczyk closed 5 years ago

stolarczyk commented 5 years ago

on dev branch

[mstolarczyk@MichalsMBP test_genomes]: export BULKERCFG="~/bulker_config.yaml"
[mstolarczyk@MichalsMBP test_genomes]: bulker init -c $BULKERCFG
Traceback (most recent call last):
  File "/Library/Frameworks/Python.framework/Versions/3.6/bin/bulker", line 10, in <module>
    sys.exit(main())
  File "/Library/Frameworks/Python.framework/Versions/3.6/lib/python3.6/site-packages/bulker/bulker.py", line 611, in main
    _is_writable(os.path.dirname(bulkercfg), check_exist=False)
  File "/Library/Frameworks/Python.framework/Versions/3.6/lib/python3.6/site-packages/bulker/bulker.py", line 196, in _is_writable
    elif create_folder:
NameError: name 'create_folder' is not defined
nsheff commented 5 years ago

should have been crate_folder maybe?

stolarczyk commented 5 years ago

the variable name does not match the one in the function signature:

https://github.com/databio/bulker/blob/81caa9b56b7fe5f6bd8222beef256fc259ff9fd4/bulker/bulker.py#L180-L196

let's use is_writable from ubiquerg here

stolarczyk commented 5 years ago

can you grant me write permissions here? I can squash bugs instead of reporting

nsheff commented 5 years ago

done.

nsheff commented 5 years ago

I think _is_writable should import from ubiquerg actually...