search

databio / bulker

Manager for multi-container computing environments
https://bulker.io
BSD 2-Clause "Simplified" License
24 stars 2 forks source link

Bulker sources bashrc, updating PATH when it likely should not #45

Closed jpsmith5 closed 4 years ago

jpsmith5 commented 4 years ago

If a user's .bashrc file prepends or appends the PATH envvar, this is carried over to bulker's path, even in --strict mode. If --strict is truly that, likely should not be calling .bashrc, or maybe it should overwrite PATH only after calling .bashrc.

nsheff commented 4 years ago

I don't think it's possible to affect the PATH after calling bashrc, and anyway, in strict mode we don't want to run that anyway.

So, strict mode now disables your .bashrc as you suggested (on dev). can you give another try?

jpsmith5 commented 4 years ago

Okay. Will try to test this out. Majority of my testing had been on local linux desktop in the office/lab, but will try to do something similar on Rivanna.

nsheff commented 4 years ago

you can of course also run bulker on your local desktop...

jpsmith5 commented 4 years ago

I haven't figured out how to run it on windows yet...

jpsmith5 commented 4 years ago

When I had done brief efforts I was having issues getting it to be callable at the command line.

jpsmith5 commented 4 years ago

Could pip install but then it didn't see bulker as a callable command.

nsheff commented 4 years ago

you're still using windows? ouch... :stuck_out_tongue_winking_eye:

https://www.howtogeek.com/413564/windows-10-is-getting-a-built-in-linux-kernel/

jpsmith5 commented 4 years ago

Cool. Hadn't come across this. Will go down the rabbit hole briefly.

nsheff commented 4 years ago

Ok the new dev branch appears to solve this... I haven't tested extensively though.

nsheff commented 4 years ago

I think this is fixed in 0.5.0. please re-open if you run into this problem again.