search

databio / pepatac

A modular, containerized pipeline for ATAC-seq data processing
http://pepatac.databio.org
BSD 2-Clause "Simplified" License
54 stars 14 forks source link

checkinstall bugs #226

Open nsheff opened 1 year ago

nsheff commented 1 year ago

@jpsmith5 what are you trying to do here?

https://github.com/databio/pepatac/blob/5c654c46bcacf94eb70794247aa7d4d36f33adff/checkinstall#L114-L117

and here:

https://github.com/databio/pepatac/blob/5c654c46bcacf94eb70794247aa7d4d36f33adff/checkinstall#L420-L422

In one version, your env var is a string file path, but in the other version (using curl), your env var is the contents of the file... so the downstream stuff can't possibly work in both situations... I'm trying to fix it but confused at what your intent was.

nsheff commented 1 year ago

Ok I think I figured it out -- this is just a bug, where it's expecting it in the first case to be path to the file, but curl is returning the contents of the file, causing it to fail.