Open vreuter opened 1 year ago
Right now, a few test assertions use the value of a constant, rather than the constant. If the constant changes, these will likely break. But the test logic is about effect of control flow on the presence of a particular conceptual file, not that the file has a particular name. As such, these test assertions should use string interpolation and the constant (DEFAULT_SAMPLE_NAME) to build the expected filename. https://github.com/databio/pypiper/blob/53850a59ef5136c620c3aeac607dee7cb1eb4f92/tests/pipeline_manager/test_pipeline_manager.py#L104-L107
DEFAULT_SAMPLE_NAME
Right now, a few test assertions use the value of a constant, rather than the constant. If the constant changes, these will likely break. But the test logic is about effect of control flow on the presence of a particular conceptual file, not that the file has a particular name. As such, these test assertions should use string interpolation and the constant (
DEFAULT_SAMPLE_NAME) to build the expected filename. https://github.com/databio/pypiper/blob/53850a59ef5136c620c3aeac607dee7cb1eb4f92/tests/pipeline_manager/test_pipeline_manager.py#L104-L107