databio / pypiper

Python toolkit for building restartable pipelines
http://pypiper.databio.org
BSD 2-Clause "Simplified" License
45 stars 9 forks source link

`logger_kwargs` isn't used in one branch of the pipeline manager setup #211

Closed vreuter closed 4 months ago

vreuter commented 6 months ago

In the pipeline manager constructor, it looks like logger_kwargs isn't used when args is non-empty or non-null. Is this intended? There's also no docstring for logger_kwargs, where it could be noted if this is indeed intended behavior, or at least describing what these values are to be used for.

https://github.com/databio/pypiper/blob/3a8465a900f15a023afc2dd0b73e30cbf2e7eb24/pypiper/manager.py#L216-L232

Possibly related to #210

vreuter commented 6 months ago

Perhaps **logger_kwargs should be passed to logmuse.init_logger?

vreuter commented 6 months ago

^^ controlling, perhaps, for possibility of collision w/ level (i.e., either remove level from the keyword args mapping if it's there--noting difference w/ DEBUG if that's the case--or not passing level='DEBUG' if level's already in the kwargs mapping.

nsheff commented 6 months ago

Hmm, I never understood what logmuse was doing with init_logger and I still don't :).

you taught me everything I know about the logging package

vreuter commented 4 months ago

Closed by https://github.com/databio/pypiper/pull/215