databox / databox-php

PHP bindings for Databox
http://databox.com
MIT License
5 stars 9 forks source link

Add support for passing options to Guzzle client #13

Closed mortenhauberg closed 5 years ago

mortenhauberg commented 5 years ago

This is useful for specifying a proxy, without relying on HTTP_PROXY and HTTPS_PROXY, for example.

The default values set in Databox\Client:16-22 cannot be changed be implementor

mortenhauberg commented 5 years ago

@VladaPetrovic any chance this could get some attention?

VladaPetrovic commented 5 years ago

Thank you @mortenhauberg for submitting this PR. Agree with your changes. 👍

mortenhauberg commented 5 years ago

Great, @VladaPetrovic. Would you guys be interested in a PR abstracting the Guzzle client, and making it a bit more flexible, so you don't rely on a specific HTTP client?