Avoid a NPE by caching the parent column for a cell

databrary / datavyu

Desktop video coding/annotation tool

http://datavyu.org/

GNU General Public License v3.0

26 stars 18 forks source link

Avoid a NPE by caching the parent column for a cell #356

Closed sethk closed 4 years ago

sethk commented 4 years ago

This fixes a NullPointerException where parentColumn was null if none of the cells in this column were focused/unfocused before the column's variable was removed by a script call. Because the NPE was triggered during evaluation of a script, the stack trace isn't shown to the user, making it harder to track this down. I may try to address that in another PR.

TheoWolf commented 4 years ago

@sethk Thanks for the contribution. It will be great if you can open an issue and link it to this PR. A description of the bug and how to reproduce it is recommended. I will review the PR and test it as soon as I can dedicate some time to Datavyu. Thanks

sethk commented 4 years ago

Sorry, I need to put this on a proper branch on my side, otherwise I can't push anything else. I'll close it, open an issue, and then file another PR.