search

databricks-industry-solutions / pixels

Facilitates simple large scale processing of HLS Medical images, documents, zip files. Previously at https://github.com/dmoore247/pixels
https://databricks-industry-solutions.github.io/pixels/
Other
25 stars 15 forks source link

Updated docs to include working with UC volumes #18

Closed krishanunandy closed 8 months ago

CLAassistant commented 1 year ago

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

:white_check_mark: krishanunandy
:x: dmoore247
You have signed the CLA already but the status is still pending? Let us recheck it.

dmoore247 commented 1 year ago

@krishanunandy Thank you for the contribution, a few items before approving...

  1. Please sign the CLA, @dbbnicole that's required, right?
  2. Please advise user in README update to use /Volumes/... (what you learned in your experience, and also what type of cluster). Thanks much!
krishanunandy commented 1 year ago

@dmoore247 I have -

  1. Signed the CLA
  2. Update the README based on your suggestions

Please let me know if you want me to make any other changes. (Also, apologies for the late reply - I didn't get a notification from Github that you'd left me a comment).

dmoore247 commented 1 year ago

@krishanunandy The reason the integration tests failed is that the fork came from your Repo instead of a branch in this Repo. Something to keep in mind for future PRs. cc: @ramgoli-db

dmoore247 commented 1 year ago

@krishanunandy There is a diagram error in the readme...

image
krishanunandy commented 11 months ago

@dmoore247

@krishanunandy The reason the integration tests failed is that the fork came from your Repo instead of a branch in this Repo. Something to keep in mind for future PRs. cc: @ramgoli-db

Good to know. In the past I had to create my own fork for contributing to Databricks Labs since only a small number of folks were given direct access to the repo.

There is a diagram error in the readme...

I'm not sure what's going on here since it renders fine in VSCode.

image

It might be something to do with Github's version of mermaid but I'll have to do some more digging.