search

databricks-industry-solutions / security-analysis-tool

Security Analysis Tool (SAT) analyzes customer's Databricks account and workspace security configurations and provides recommendations that help them follow Databrick's security best practices. When a customer runs SAT, it will compare their workspace configurations against a set of security best practices and delivers a report.
Other
86 stars 39 forks source link

ws_client.get_wssettings_list KeyError: 'enableNotebookGitVersioning' #151

Open v1adev opened 1 day ago

v1adev commented 1 day ago

The bootstrap('workspacesettings'+ '_' + workspace_id, ws_client.get_wssettings_list) call started failing with the following error last week (in Azure Databricks). Could possibly be related to the retirement of the legacy Git version control? https://learn.microsoft.com/en-us/azure/databricks/archive/repos/git-version-control-legacy

2024-10-07 12:07:50,562 - _profiler_ - ERROR - Exception encountered
Traceback (most recent call last):
  File "/root/.ipykernel/1714/command-339720792581471-1775977341", line 15, in bootstrap
    lst = func(**kwargs)
          ^^^^^^^^^^^^^^
  File "/local_disk0/.ephemeral_nfs/cluster_libraries/python/lib/python3.11/site-packages/clientpkgs/ws_settings_client.py", line 65, in get_wssettings_list
    valins['value']=None if valn[keyn['name']] is None else valn[keyn['name']]
                            ~~~~^^^^^^^^^^^^^^
KeyError: 'enableNotebookGitVersioning'
arunpamulapati commented 15 hours ago

Yes this will be disabled as our product removed the the API call in addition to this now is a legacy concept.

v1adev commented 15 hours ago

That makes sense. Unfortunately, this silently prevents the workspacesettings temp table from being populated during the bootstrap phase which impacts all checks that are based on that.

arunpamulapati commented 14 hours ago

Yes, we will need to deep clean it, please stay tuned it will take a bit of time.