databricks / cli

Databricks CLI
Other
115 stars 39 forks source link

Fix non-default project names not working in dbt-sql template #1500

Closed kijewskimateusz closed 10 hours ago

kijewskimateusz commented 2 weeks ago

Changes

Hello Team,

While tinkering with your solution, I've noticed that profiles provided in dbt_project.yml and profiles.yml for generated dbt asset bundles. do not align. This led to the following error, when deploying DAB:

+ dbt deps --target=dev
11:24:02  Running with dbt=1.8.2
11:24:02  Warning: No packages were found in packages.yml
11:24:02  Warning: No packages were found in packages.yml

+ dbt seed --target=dev --vars '{ dev_schema: mateusz_kijewski }'
11:24:05  Running with dbt=1.8.2
11:24:05  Encountered an error:
Runtime Error
  Could not find profile named 'dbt_sql'

I have corrected profile name in profiles.yml.tmpl to the name used in dbt_project.yml.tmpl. Using the opportunity of forking your repo, I've also updated tests configuration in model config as starting of dbt v1.8 it's been raising warnings of configuration change from tests to data_tests

11:31:34  [WARNING]: Deprecated functionality
The `tests` config has been renamed to `data_tests`. Please see
https://docs.getdbt.com/docs/build/data-tests#new-data_tests-syntax for more
information.

Tests

lennartkats-db commented 1 week ago

This is great @kijewskimateusz, thanks for your original report and your contribution!

I tested these changes and they work as expected.

pietern commented 1 week ago

@kijewskimateusz Thanks for your contribution! We need a CLA to be signed for contributions to this repository. Could you send an email to dabs-preview@databricks.com and include your name and then we can take it from there.