search

databricks / cli

Databricks CLI
Other
148 stars 56 forks source link

Print text logs in `import-dir` and `export-dir` commands #1682

Closed shreyas-goenka closed 3 months ago

shreyas-goenka commented 3 months ago

Changes

In https://github.com/databricks/cli/pull/1202 the semantics of cmdio.RenderJson was changes to always render the JSON object. Before we would only render it if --output json was specified.

This PR fixes the logs to print human-readable log lines instead of a JSON object. This PR also removes the now unused cmdio.Render method.

Tests

Manually:

➜  bundle-playground git:(master) ✗ cli workspace import-dir ./tmp /Users/shreyas.goenka@databricks.com/test-import-1 -p aws-prod-ucws
Importing files from ./tmp
a -> /Users/shreyas.goenka@databricks.com/test-import-1/a
Import complete. The files are available at /Users/shreyas.goenka@databricks.com/test-import-1
➜  bundle-playground git:(master) ✗ cli workspace export-dir  /Users/shreyas.goenka@databricks.com/test-export-1 ./tmp-2 -p aws-prod-ucws
Exporting files from /Users/shreyas.goenka@databricks.com/test-export-1
/Users/shreyas.goenka@databricks.com/test-export-1/b -> tmp-2/b
Exported complete. The files are available at ./tmp-2
shreyas-goenka commented 3 months ago

Triggered nightlies on this PR.