search

databricks / cli

Databricks CLI
Other
150 stars 56 forks source link

Fix workspace extensions filer accidentally reading notebooks #1891

Closed shreyas-goenka closed 4 days ago

shreyas-goenka commented 2 weeks ago

Changes

The workspace extensions filer should not read or stat a notebook called foo if the user calls .Stat(ctx, "foo").

Instead, the filer should return a file not found error. This is because the contract for the workspace extensions filer is to only work for notebooks when the file path / name includes the extension (example: foo.ipynb or foo.sql instead of just foo)

Tests

Integration tests.

github-actions[bot] commented 4 days ago

If integration tests don't run automatically, an authorized user can run them manually by following the instructions below:

Trigger: go/deco-tests-run/cli

Inputs:

Checks will be approved automatically on success.

eng-dev-ecosystem-bot commented 4 days ago

Test Details: go/deco-tests/11895948996