search

databricks / click

The "Command Line Interactive Controller for Kubernetes"
Apache License 2.0
1.49k stars 84 forks source link

Accessing a cluster without a cert #27

Closed rampage644 closed 6 years ago

rampage644 commented 6 years ago

Hello,

Thanks for such a nice project! Kudos!

While trying to connect to insecure cluster, click outputs "Can't do insecure-skip-tls-verify yet". Obviously, it is not supported yet. Is there an estimate when such setups will be supported?

gabel commented 6 years ago

Especially for the Docker Edge version with Kubernetes build-in on a local machine (e.g. Mac OS) this is required.

✗ click
Can't do insecure-skip-tls-verify yet, ignoring cluster: docker-for-desktop-cluster
skeenan947 commented 6 years ago

Love this project! Can't wait to use it, but this feature is pretty important - I can't make use of click without it.

wieslaw-gat commented 6 years ago

+1, as this sounds very useful.

As a side note: you can work around this limitation by passing --embed-certs=true and --certificate-authority=path_to_custom_cluster_crt to kubectl config set-cluster instead of --insecure-skip-tls-verify=true

rampage644 commented 6 years ago

@wieslaw-gat Thanks for a workaround!

nicklan commented 6 years ago

Yeah, the problem with insecure-skip-tls-verify is that it's only supported in much newer versions of Hyper, and doing that upgrade is a big project as they've moved everything over to tokio. It's very much something I want to do asap, but will need to find the time too. I will look at if there's a more hacky workaround to support this sooner.

nicklan commented 6 years ago

Actually, turns out it was easy to get a new enough version of rustls to support this. Will merge support in a sec