databricks / click

The "Command Line Interactive Controller for Kubernetes"
Apache License 2.0
1.49k stars 84 forks source link

Make things work when the server is specified by IP #7

Closed nicklan closed 6 years ago

nicklan commented 6 years ago

webpki does not support IP Address SANS, and that's what minikube uses, so without this we can't talk to mikikube clusters. This is essentially safe, as it's just saying, hey, if the .kube/config is pointing at an IP address, try and find a hostname we can use instead. We do require that the specified IP is in the cert, so it won't enable connecting just anywhere. The DNS override to make this work is done in connector.rs.