databricks / databricks-sdk-go

Databricks SDK for Go
https://docs.databricks.com/dev-tools/sdk-go.html
Apache License 2.0
46 stars 38 forks source link

[discuss] Don't generate shortcuts for list functions #935

Open pietern opened 1 month ago

pietern commented 1 month ago

Changes

The ListByZZZ functions don't use the same pagination as the main functions.

By definition, the shortcut functions are generated only if there are required request parameters. Therefore, they should either return the same paginator, or not exist at all.

Tests

n/a

codecov-commenter commented 1 month ago

Codecov Report

Attention: Patch coverage is 0% with 6 lines in your changes are missing coverage. Please review.

Project coverage is 7.13%. Comparing base (29bdcf3) to head (515ea4c). Report is 1 commits behind head on main.

Files Patch % Lines
service/compute/library_utilities.go 0.00% 4 Missing :warning:
openapi/code/method.go 0.00% 1 Missing and 1 partial :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #935 +/- ## ======================================== - Coverage 7.13% 7.13% -0.01% ======================================== Files 281 281 Lines 64583 64596 +13 ======================================== Hits 4609 4609 - Misses 59666 59677 +11 - Partials 308 310 +2 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.