Open renaudhartert-db opened 1 week ago
All modified and coverable lines are covered by tests :white_check_mark:
Please upload report for BASE (
main@ce3dc98
). Learn more about missing BASE report.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Changes
This PR does a minor noop refactoring of
apierr/error_override_test.go
to better match the style of idiomatic table-tests. In particular, it:applyOverridesTestCase
struct which is replaced with an anonymous struct. There's nothing wrong with that struct per se but seeing it made me think at first that it was doing more than simply defining the table cases.name
field (was always "") and remove the subtests rather than giving them an arbitrary name (e.g. the index of the test).Alternatively, we could give meaningful names to the subtests and keep them. Though, what these names should be was not obvious to me.
Tests
The test coverage is the same as before this change.
make test
passingmake fmt
applied