search

databricks / databricks-sdk-py

Databricks SDK for Python (Beta)
https://databricks-sdk-py.readthedocs.io/
Apache License 2.0
318 stars 103 forks source link

fix windows path (#660) #673

Closed parthban-db closed 1 week ago

parthban-db commented 4 weeks ago

Changes

Changed pathlib.Path with the pathlib.PurePosixPath in /databricks/sdk/mixins/files.py which always use linux path separators regardless of the OS that it is running on. Fixes (#660)

Tests

github-actions[bot] commented 4 weeks ago

This PR breaks backwards compatibility for databrickslabs/ucx downstream. See build logs for more details.

Running from downstreams #189

codecov-commenter commented 4 weeks ago

Codecov Report

Attention: Patch coverage is 80.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 57.70%. Comparing base (455a14c) to head (bc276ae). Report is 1 commits behind head on main.

Files Patch % Lines
databricks/sdk/mixins/files.py 80.00% 2 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #673 +/- ## ========================================== + Coverage 57.69% 57.70% +0.01% ========================================== Files 48 48 Lines 33079 33085 +6 ========================================== + Hits 19084 19091 +7 + Misses 13995 13994 -1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

edwardfeng-db commented 4 weeks ago

Can you link the github issue that this PR solves in the PR description?