Fix Spark parameter creation when passing a `nil`-value named parameter to a query

databricks / databricks-sql-go

Golang database/sql driver for Databricks SQL.

Apache License 2.0

37 stars 41 forks source link

Fix Spark parameter creation when passing a `nil`-value named parameter to a query #199

Closed esdrasbeleza closed 7 months ago

esdrasbeleza commented 7 months ago

When a sql.NamedValue has the field Value set to nil, the resulting cli_service.TSparkParameter will also have the value nil instead of *cli_service.TSparkParameterValue{StringValue: *"%!s(<nil>"}.
Add the type SqlVoid, following the conventions used in the NodeJS connector and the Python driver.

Fix #193.

kravets-levko commented 7 months ago

@esdrasbeleza Can you please rebase and resolve conflicts? Thanks!

esdrasbeleza commented 7 months ago

@kravets-levko got a bit lost in the process with merges, rebases, signoffs etc., but it's done 😅 10+ years of git and it's never enough!

esdrasbeleza commented 7 months ago

@kravets-levko any plans to merge this? My current code base is full of hacky queries because of this issue 🙏

kravets-levko commented 7 months ago

@esdrasbeleza Merged 👍 I'd like to ship one more PR with this release - waiting for a person to rebase their branch and we're good to go. After that I'll cut a release ASAP