search

databricks / databricks-sql-go

Golang database/sql driver for Databricks SQL.
Apache License 2.0
34 stars 37 forks source link

hotfix: Provide content length on file put #212

Closed candiduslynx closed 2 months ago

candiduslynx commented 2 months ago

Closes https://github.com/databricks/databricks-sql-go/issues/211

candiduslynx commented 2 months ago

@kravets-levko kindly review this ASAP & release a new version

kravets-levko commented 2 months ago

@candiduslynx I would like to ask you to add some tests to avoid regressions in future. Thank you!

candiduslynx commented 2 months ago

@candiduslynx I would like to ask you to add some tests to avoid regressions in future. Thank you!

@kravets-levko why the requirement wasn't added in the first place (when the original PR was merged)? Anyways, the issue is that the only way to properly test this is to send the request to the backend, so it will require your team to set up a proper backend (serverless databricks?) for testing such scenarios.

That's why I think it should be done on your side (or, at least, the set up of backend & gh secrets should be done prior to creating a test that utilizes the put functionality). WDYT?

candiduslynx commented 2 months ago

@kravets-levko I'm closing this PR in favor of https://github.com/databricks/databricks-sql-go/pull/217 (opened from the org fork instead of private one)