Closed kravets-levko closed 9 months ago
Attention: 1 lines
in your changes are missing coverage. Please review.
Comparison is base (
3953e5d
) 0.00% compared to head (e82d2ed
) 90.67%.
Files | Patch % | Lines |
---|---|---|
...ib/connection/auth/DatabricksOAuth/OAuthManager.ts | 96.29% | 0 Missing and 1 partial :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Fixes databricks/databricks-sql-nodejs#226
This PR also contains some preparation work/refactoring, and is easier to review commit by commit:
clientSecret
option, but now this condition is moved all the way up toDBSQLClient
.OAuthManager
uses dedicated option to choose which flow to use