Cancel python models on Ctrl-C

databricks / dbt-databricks

A dbt adapter for Databricks.

https://databricks.com

Apache License 2.0

195 stars 104 forks source link

Cancel python models on Ctrl-C #693

Closed benc-db closed 3 weeks ago

benc-db commented 3 weeks ago

Resolves #684

Description

When you cancel a running dbt job, running SQL queries are cancelled. This PR extends #690 to propagate the cancel behavior to python models.

Checklist

[x] I have run this code in development and it appears to resolve the stated issue
[x] This PR includes tests, or tests are not required/relevant for this PR
[x] I have updated the CHANGELOG.md and added information about my change to the "dbt-databricks next" section.

gaoshihang commented 3 weeks ago

Hi @benc-db I have tested our scenario, everything runs smoothly, the python model can be canceled! Thank you very much!

It's very pleasure to work with you.

gaoshihang commented 3 weeks ago

Hi @benc-db Thanks for work on this. I still have a question, if we want to use this feature, which version should we use?

benc-db commented 3 weeks ago

Hi @benc-db Thanks for work on this. I still have a question, if we want to use this feature, which version should we use? Hasn't been released yet, will be part of 1.8.2.

gaoshihang commented 3 weeks ago

@benc-db Thanks!