databricks / koalas

Koalas: pandas API on Apache Spark
Apache License 2.0
3.32k stars 356 forks source link

Remove upperbound pandas 1.2 #2141

Closed itholic closed 3 years ago

itholic commented 3 years ago

Fix several incompatible behavior with pandas in iLocIndexer to remove upperbound pandas 1.2.

codecov-io commented 3 years ago

Codecov Report

Merging #2141 (dcbe6a6) into master (0fd088e) will decrease coverage by 0.90%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2141      +/-   ##
==========================================
- Coverage   95.37%   94.46%   -0.91%     
==========================================
  Files          60       60              
  Lines       13694    13702       +8     
==========================================
- Hits        13060    12944     -116     
- Misses        634      758     +124     
Impacted Files Coverage Δ
databricks/koalas/indexing.py 92.77% <100.00%> (-0.07%) :arrow_down:
databricks/koalas/usage_logging/__init__.py 27.27% <0.00%> (-65.29%) :arrow_down:
databricks/koalas/usage_logging/usage_logger.py 47.82% <0.00%> (-52.18%) :arrow_down:
databricks/conftest.py 93.75% <0.00%> (-6.25%) :arrow_down:
databricks/koalas/typedef/typehints.py 89.28% <0.00%> (-6.13%) :arrow_down:
databricks/koalas/__init__.py 88.15% <0.00%> (-3.95%) :arrow_down:
databricks/koalas/tests/indexes/test_category.py 98.21% <0.00%> (-1.79%) :arrow_down:
databricks/koalas/tests/indexes/test_datetime.py 98.27% <0.00%> (-1.73%) :arrow_down:
databricks/koalas/indexes/datetimes.py 95.91% <0.00%> (-1.37%) :arrow_down:
databricks/koalas/tests/indexes/test_base.py 99.40% <0.00%> (-0.60%) :arrow_down:
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 0fd088e...dcbe6a6. Read the comment docs.

itholic commented 3 years ago

Thanks, @ueshin ! Merging :-)

HyukjinKwon commented 3 years ago

@itholic can you make this change in Apache Spark too?

ueshin commented 3 years ago

I filed a JIRA ticket to track the additional changes. https://issues.apache.org/jira/browse/SPARK-34995