databricks / learning-spark

Example code from Learning Spark book
MIT License
3.89k stars 2.42k forks source link

directly use Configuration instead of getting from job in BasicSaveProtobuf example #7

Closed huydx closed 9 years ago

huydx commented 9 years ago

Directly using Job in this way is deprecated

https://github.com/apache/hadoop/blob/c1d50a91f7c05e4aaf4655380c8dcd11703ff158/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapreduce/Job.java#L116

Moreover, we just don't need to use Job, directly use of Configuration seems to be easier to understand.

holdenk commented 9 years ago

LGTM