Azure DevOps bundle cli installer update

databricks / mlops-stacks

This repo provides a customizable stack for starting new ML projects on Databricks that follow production best-practices out of the box.

https://docs.databricks.com/en/dev-tools/bundles/mlops-stacks.html

Apache License 2.0

456 stars 156 forks source link

Azure DevOps bundle cli installer update #82

Closed niall-turbitt closed 1 year ago

niall-turbitt commented 1 year ago

Update Azure Pipelines to install Databricks CLI using curl -fsSL https://raw.githubusercontent.com/databricks/setup-cli/main/install.sh | sh rather than the installer script within the repo
Remove installer script
Fix typo error on SP prod tenant ID

niall-turbitt commented 1 year ago

LGTM just one question, I notice we don't supply architecture anymore, is that taken care of by the install.sh script?

@arpitjasa-db I assume so as I did not need to pass that as an env var when testing. @pietern can you confirm this?

vladimirk-db commented 1 year ago

LGTM just one question, I notice we don't supply architecture anymore, is that taken care of by the install.sh script?

@arpitjasa-db I assume so as I did not need to pass that as an env var when testing. @pietern can you confirm this?

It's taken care of by the script: https://raw.githubusercontent.com/databricks/setup-cli/main/install.sh

niall-turbitt commented 1 year ago

@niall-turbitt Before merging, could you please update [...]-tests-ci.yml to run just databricks version instead of databricks version --detail? The latter is going away in favor of --output json to be consistent with other commands.

I believe this is the only callsite with the --detail flag.

done! And also removed the pre-existing env var declaring the version. Thanks for reviewing @pietern

pietern commented 1 year ago

@niall-turbitt Thank you!