databricks / mlops-stacks

This repo provides a customizable stack for starting new ML projects on Databricks that follow production best-practices out of the box.
https://docs.databricks.com/en/dev-tools/bundles/mlops-stacks.html
Apache License 2.0
425 stars 143 forks source link

Migrate Mlops Stacks to use databricks asset templates for project creation #96

Closed mingyu89 closed 1 year ago

mingyu89 commented 1 year ago

The project is thoroughly tested by using different input parameter combinations and compare the created project by cookiecutter and asset templates. There's no need to do bugbash or manual integration test since there's no change to the project output.

For easier review: The diff of test changes is in https://github.com/databricks/mlops-stack/pull/97 The diff of changes is in https://github.com/databricks/mlops-stack/pull/98

Design doc and validation Link

https://docs.google.com/document/d/19MOK9o-f0A_-NMmxC1cJGQSQ2WkJXZ4vXQZ4plu-tng/edit#bookmark=id.tsk81t8hk8bf

Sanity Check

Created project successfully run bundle deploy for staging and prod

Screenshot 2023-09-06 at 5 48 32 PM

Test PR feature=>staging of generated project https://github.com/mingyu89/test-repo1/pull/27 Successful unit test and integration test in test(E2-dogfood) environment https://github.com/mingyu89/test-repo1/actions/runs/6104146227/job/16565759289?pr=27

Screenshot 2023-09-06 at 6 28 11 PM

Validation

No. Test Case Validation Status Diff Link
1 All parameters are default Validated https://github.com/mingyu89/test-repo1/pull/15/files
2 azure + github + delta Validated https://github.com/mingyu89/test-repo1/pull/16/files
3 azure + github + feature store Validated https://github.com/mingyu89/test-repo1/pull/17/files
4 azure + github + recipes Validated https://github.com/mingyu89/test-repo1/pull/18/files
5 aws + github enterprise + delta Validated https://github.com/mingyu89/test-repo1/pull/19/files
6 aws + github enterprise + feature store Validated https://github.com/mingyu89/test-repo1/pull/20/files
7 aws + github enterprise + recipes Validated https://github.com/mingyu89/test-repo1/pull/21/files
8 azure + ADO + delta Validated https://github.com/mingyu89/test-repo1/pull/22/files
9 azure + ADO + feature store Validated https://github.com/mingyu89/test-repo1/pull/23/files
10 aws + github + delta Validated https://github.com/mingyu89/test-repo1/pull/24/files
11 aws + github + feature store Validated https://github.com/mingyu89/test-repo1/pull/25/files
12 Default branch is the same as release branch Validated https://github.com/mingyu89/test-repo1/pull/26/files
13 invalid combination of aws + ADO Validated
14 invalid project name Validated
15 invalid selection of cloud/platform/feature store/recipes Validated
16 invalid staging host Validated
17 invalid prod host Validated
18 invalid characters in project name Validated