search

databricks / sbt-databricks

An sbt plugin for deploying code to Databricks Cloud
http://go.databricks.com/register-for-dbc
Other
71 stars 27 forks source link

Set TLSv1.2 as default protocol #16

Closed ahirreddy closed 8 years ago

ahirreddy commented 8 years ago

Fixes an issue communicating with newer versions of Databricks.

ahirreddy commented 8 years ago

@brkyvz I think the tests might be broken. They passed even though there was a failure:

[info] [success] Total time: 1 s, completed Dec 1, 2015 8:23:46 PM
[info] org.apache.http.client.HttpResponseException
[info]  at org.apache.http.impl.client.BasicResponseHandler.handleResponse(BasicResponseHandler.java:67)
[info]  at sbtdatabricks.DatabricksHttp.fetchClusters(DatabricksHttp.scala:329)
[info]  at sbtdatabricks.DatabricksPlugin$$anonfun$19.apply(DatabricksPlugin.scala:323)
[info]  at sbtdatabricks.DatabricksPlugin$$anonfun$19.apply(DatabricksPlugin.scala:323)
[info]  at scala.Function1$$anonfun$compose$1.apply(Function1.scala:47)
[info]  at sbt.$tilde$greater$$anonfun$$u2219$1.apply(TypeFunctions.scala:40)
[info]  at sbt.std.Transform$$anon$4.work(System.scala:63)
[info]  at sbt.Execute$$anonfun$submit$1$$anonfun$apply$1.apply(Execute.scala:226)
[info]  at sbt.Execute$$anonfun$submit$1$$anonfun$apply$1.apply(Execute.scala:226)
[info]  at sbt.ErrorHandling$.wideConvert(ErrorHandling.scala:17)
[info]  at sbt.Execute.work(Execute.scala:235)
[info]  at sbt.Execute$$anonfun$submit$1.apply(Execute.scala:226)
[info]  at sbt.Execute$$anonfun$submit$1.apply(Execute.scala:226)
[info]  at sbt.ConcurrentRestrictions$$anon$4$$anonfun$1.apply(ConcurrentRestrictions.scala:159)
[info]  at sbt.CompletionService$$anon$2.call(CompletionService.scala:28)
[info]  at java.util.concurrent.FutureTask.run(FutureTask.java:262)
[info]  at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:471)
[info]  at java.util.concurrent.FutureTask.run(FutureTask.java:262)
[info]  at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145)
[info]  at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615)
[info]  at java.lang.Thread.run(Thread.java:745)
[info] [error] (serverError/*:dbcFetchClusters) org.apache.http.client.HttpResponseException
[info] [error] Total time: 0 s, completed Dec 1, 2015 8:23:47 PM
marmbrus commented 8 years ago

Confirmed the fix locally.

brkyvz commented 8 years ago

Thanks @ahirreddy! LGTM Thanks @marmbrus for confirming!