search

databricks / sbt-databricks

An sbt plugin for deploying code to Databricks Cloud
http://go.databricks.com/register-for-dbc
Other
71 stars 27 forks source link

Add support for attachToAllClusters to dbcUpload #19

Closed jakajancar closed 8 years ago

brkyvz commented 8 years ago

Hi @jakajancar, You should be able to achieve this already using 

dbcClusters := Seq("DBC_ALL_CLUSTERS")

Would that help, or do you have a separate use case?

Thanks!

jakajancar commented 8 years ago

@brkyvz This checks all clusters (red) as opposed the "all clusters" checkbox (green):

screenshot

jakajancar commented 8 years ago

Alternatively, perhaps instead of attachToAllClusters in dbcUpload simply DBC_ALL_CLUSTERS should be changed from "ALL_CLUSTERS" to "__ALL_CLUSTERS" and the special handling removed, and dbcAttach would be used (although an extra unnecessary API call).

jakajancar commented 8 years ago

@brkyvz Any thoughts on this?

brkyvz commented 8 years ago

Hi @jakajancar, It would be a simple single line addition. I can make the change that if

dbcClusters := Seq("DBC_ALL_CLUSTERS")

then we will "click" that green checkbox. I'll submit a PR momentarily.

jakajancar commented 8 years ago

OK, let me know when you're done and I can test.

brkyvz commented 8 years ago

Resolved with PR #20

brkyvz commented 8 years ago

@jakajancar Released v0.1.4!