search

databricks / spark-pr-dashboard

Dashboard to aid in Spark pull request reviews
spark-prs.appspot.com
Apache License 2.0
54 stars 46 forks source link

Filter out Jenkins build trigger comments #11

Closed liancheng closed 10 years ago

liancheng commented 10 years ago

There's no need to show comments like "Jenkins, test this please" in the tooltip since Jenkins build status has already been displayed.

The spec of "how to talk to Jenkins" can be found here.

JoshRosen commented 10 years ago

Good idea. We should filter out comments that only say Jenkins commands, since sometimes those commands appear as part of a larger comment.

Maybe we should add a status to the Jenkins Status column to indicate "Queued" or "Waiting" to show that Jenkins has been asked to test a PR but that it hasn't started yet.

JoshRosen commented 10 years ago

The site is now running a prototype of this. I added a new Jenkins status to represent states where we've asked Jenkins to run tests but they haven't started yet.

For now, I used the same comment glyphicon for this state, since it's similar to "Admin Needed." I'm open to suggestions for a different icon (or a complete icon /design overhaul). Note that we can also use icons from GitHub's octicons set.