databricks / spark-pr-dashboard

Dashboard to aid in Spark pull request reviews
spark-prs.appspot.com
Apache License 2.0
54 stars 46 forks source link

Display timestamp in comment popovers #18

Closed JoshRosen closed 9 years ago

JoshRosen commented 10 years ago

It would be nice to display a human-readable timestamp in the header of the comment popovers. I tried doing this but ran into some problems with the library that we use for formatting times: to avoid a "flickering" effect where users can observe the raw timestamp being reformatted, we ideally should call the time library after creating the popover DOM elements but before displaying them to the user. I couldn't find an easy hook to do this.

(This feature is Shivaram's suggestion).