search

databricks / spark-pr-dashboard

Dashboard to aid in Spark pull request reviews
spark-prs.appspot.com
Apache License 2.0
54 stars 46 forks source link

Show which tests failed #24

Closed marmbrus closed 10 years ago

marmbrus commented 10 years ago

Often the test failures are unrelated to the PR and since we'll probably never have perfect tests across the board, it would be nice to see that at a glance. This could either be the failing subproject (i.e., streaming-kafka/test:test) or the actual test suite that failed(i.e., org.apache.spark.streaming.kafka.KafkaStreamSuite)

nchammas commented 10 years ago

Michael, do you want this change to be made to the dev/run-tests-jenkins script which posts messages to GitHub, or do you see this being something added to the PR dashboard?

marmbrus commented 10 years ago

I was thinking the PR dashboard, but now that you mention it both would actually be nice.

pwendell commented 10 years ago

What about this:

  1. Have dev/run-tests-jenkins post some useful information about failed tests.
  2. Allow you to hover over "test failed" and click and see the comment that Jenkins posted (we have this machinery for showing comments already on click).
marmbrus commented 10 years ago

Oh yeah, that's probably easier than having the PR board talk to Jenkins. On Sep 8, 2014 8:08 PM, "Patrick Wendell" notifications@github.com wrote:

What about this:

  1. Have dev/run-tests-jenkins post some useful information about failed tests.
  2. Allow you to hover over "test failed" and click and see the comment that Jenkins posted (we have this machinery for showing comments already on click).

— Reply to this email directly or view it on GitHub https://github.com/databricks/spark-pr-dashboard/issues/24#issuecomment-54918650 .

nchammas commented 10 years ago

Sounds good to me. For the Jenkins side of this work, shall we track that with another sub-task on SPARK-2230? I'd be happy to work on having Jenkins post info about what tests failed directly in his GitHub messages.

nchammas commented 10 years ago

I've created SPARK-3479 for the Jenkins work to cover this.

JoshRosen commented 10 years ago

I just pushed support for popovers that display the comment associated with the last Jenkins outcome. This may take a while to become enabled for all PRs, since unfortunately this requires a bulk re-indexing (should be totally finished within an hour; most active PRs should already have this).

nchammas commented 10 years ago

Just tried it out. That is super neat, Josh.

JoshRosen commented 10 years ago

Thanks to @nchammas, Spark now reports the failed test's category: https://github.com/apache/spark/pull/2606