search

databricks / spark-pr-dashboard

Dashboard to aid in Spark pull request reviews
spark-prs.appspot.com
Apache License 2.0
54 stars 46 forks source link

Add "All" component (#25). #28

Closed nchammas closed 10 years ago

nchammas commented 10 years ago

As proposed in #25. Dunno if we need a better way to do this, since "All" is not technically a component.

JoshRosen commented 10 years ago

This will probably blow up the size of the rendered HTML, since we'll now be guaranteed to list each issue twice. If we care about performance, we could return a JSON object containing information on all issues and do the grouping-by-component and tab construction on the client-side (D3 would be great for this). On the other hand, maybe gzip compression means that the HTML size difference is negligible.

nchammas commented 10 years ago

Ah, I see. Grouping on the client side seems like the cleaner way to go. I'll close this.