search

databricks / spark-pr-dashboard

Dashboard to aid in Spark pull request reviews
spark-prs.appspot.com
Apache License 2.0
54 stars 46 forks source link

Open Jenkins in a separate tab after clicking the "Test with Jenkins" button #29

Closed liancheng closed 9 years ago

liancheng commented 10 years ago

Usually I wish to stay in the dashboard page to process the next PR instead of examine Jenkins output.

JoshRosen commented 10 years ago

I can add this tomorrow. Davies wrote a pretty neat bookmarklet that lets you retest a PR from GitHub without having to go back to spark-prs:

javascript:void(function(){var d=document,r='https://spark-prs.appspot.com/trigger-jenkins/'+d.location.href.match(/pull\/(\d+)/)[1],x=function(){if(!window.open(r,'jenkins','toolbar=0,resizable=0,scrollbars=no,status=1,width=50,height=50'))location.href=r};if(/Firefox/.test(navigator.userAgent)){setTimeout(x,0)}else{x()}})()

I've been using this to trigger builds (which is why #30 is annoying to me).

JoshRosen commented 9 years ago

This was fixed as part of the new React.js frontend (#33).