databricks / spark-pr-dashboard

Dashboard to aid in Spark pull request reviews
spark-prs.appspot.com
Apache License 2.0
54 stars 46 forks source link

Display mergeability #3

Closed JoshRosen closed 10 years ago

JoshRosen commented 10 years ago

It might be nice to add a column showing whether a PR is cleanly mergeable or not.

Minor design issue: if we use a checkmark / red 'x' to indicate the status, this might become visually confusing or make it harder to see the "Last Jenkins Outcome." I'm open to suggestions for how to handle this, including changes to the Jenkins status column.

pwendell commented 10 years ago

I think it's fine to use similar "check or X" style. At least I've seen this in other dashboards, then you can make sure you have "all greens" before you try to merge it.