search

databricks / spark-pr-dashboard

Dashboard to aid in Spark pull request reviews
spark-prs.appspot.com
Apache License 2.0
54 stars 46 forks source link

Allow PRs to be closed directly from PR dashboard #40

Closed nchammas closed 9 years ago

nchammas commented 9 years ago

Sometimes, it takes a while for contributors to get around to closing PRs, even when asked.

We already have a (hackish) way of closing PRs directly. If possible, let's automate that process and allow committers to close PRs directly from the dashboard with a click (and perhaps also a confirmation).

nchammas commented 9 years ago

@pwendell What is the procedure we follow when we do close PRs ourselves?

JoshRosen commented 9 years ago

@pwendell has a script which searches through the open PRS for comments containing a certain trigger phrase, then compiles a commit message with lines to close those PRs.

JoshRosen commented 9 years ago

Oh, and regarding procedure, I think we've just been running this manually once we've accumulated enough "asked to close" PRs. The batching ensures that we don't pollute the commit history with tons of automatic PR closing commits.

nchammas commented 9 years ago

Okie doke. So I gather there's no need for a feature in the PR dashboard for this right?

JoshRosen commented 9 years ago

Meh, I'll probably add it in at some point since it's not a huge amount of work, so let's leave this issue open for now.