search

databricks / spark-pr-dashboard

Dashboard to aid in Spark pull request reviews
spark-prs.appspot.com
Apache License 2.0
54 stars 46 forks source link

Updated column should include line comments #43

Closed nchammas closed 8 years ago

nchammas commented 9 years ago

It looks like the updated column only tracks comments on the PR as a whole, and not line comments. We probably want to include both.

JoshRosen commented 9 years ago

This is based off of the updated_at value delivered from GitHub, which in principle should incorporate updates due to line comments on the PR itself. I'm going to close this as "cannot reproduce" for now.

JoshRosen commented 9 years ago

Actually, this does look like a legit. problem and I have an idea of how to fix it, so I'm going to re-open.