search

databricks / spark-pr-dashboard

Dashboard to aid in Spark pull request reviews
spark-prs.appspot.com
Apache License 2.0
54 stars 46 forks source link

Get pinged for any PR that touches files you care about #47

Closed nchammas closed 2 years ago

nchammas commented 9 years ago

This is a direct ripoff of Phabricator's Herald, but it might be very useful if we had some rudimentary PR notification system.

Basically: If a PR touches any file that contains this string in its name, ping these people.

shivaram commented 9 years ago

Instead of a file-level granularity it might even be enough to have be per-component. So users can subscribe to Python, EC2 or something like that

nchammas commented 9 years ago

That sounds good to me.

JoshRosen commented 9 years ago

Instead of having Spark PRs be responsible for sending messages, what if we provided per-component RSS feeds? There's already a nice ecosystem of tools for transforming RSS feeds into your notification of choice (emails, irc messages, tweets, etc). This could probably be hacked together in an hour or so, tops.

nchammas commented 2 years ago

Something like this can be done with GitHub teams and CODEOWNERS. It's not as flexible as a system for arbitrary PR activity subscriptions, but perhaps it's good enough.