search

databricks / spark-pr-dashboard

Dashboard to aid in Spark pull request reviews
spark-prs.appspot.com
Apache License 2.0
54 stars 46 forks source link

Highlight people who have said LGTM #5

Closed pwendell closed 10 years ago

pwendell commented 10 years ago

We should put some kind of subtle box around people who have said LGTM to a pull requests. We could also later on do this only for committers.

JoshRosen commented 10 years ago

Should it highlight anyone who has ever said LGTM in any comment on the PR?

pwendell commented 10 years ago

As a start I think it would be nice to highlight anyone. We could decide later to restrict it to committers.

JoshRosen commented 10 years ago

There's a preview version of this running on the live site, but I'm not sure how useful it actually is.

pwendell commented 10 years ago

For my part, I find this quite useful.

On Wed, Sep 3, 2014 at 2:09 PM, Josh Rosen notifications@github.com wrote:

Closed #5 https://github.com/databricks/spark-pr-dashboard/issues/5 via 430c567 https://github.com/databricks/spark-pr-dashboard/commit/430c567e0392a9b1b52d02277232251232986db3 .

Reply to this email directly or view it on GitHub https://github.com/databricks/spark-pr-dashboard/issues/5#event-160830500 .