search

databricks / spark-pr-dashboard

Dashboard to aid in Spark pull request reviews
spark-prs.appspot.com
Apache License 2.0
54 stars 46 forks source link

Show a user's latest comment in a tooltip #6

Closed pwendell closed 10 years ago

pwendell commented 10 years ago

For the little images that display next to each user's profile, it would be cool to display a tooltip with the contents of the user's latest comment.

JoshRosen commented 10 years ago

I've pushed a preview version of this to the live site. Screenshot:

image

shivaram commented 10 years ago

This looks great - Minor request: Could you also add a timestamp next to the 'Comment from' line ? That might make it easier to figure out who has replied last

JoshRosen commented 10 years ago

@shivaram From left-to-right, the comments are displayed in reverse chronological order based on who's replied most recently. However, it only shows the most recent comment from each commenter; there could be multiple comments that occurred between commenter icons that aren't being shown.

Maybe the UI should explain this somehow (a tooltip on "Commenters" or something?).

That said, it's not hard to add a timestamp in the comment's header.

pwendell commented 10 years ago

@JoshRosen could we have this enabled on hover instead of on click? At least on Chrome/Linux I find I have to click it to see the comment.

JoshRosen commented 10 years ago

@pwendell If it displayed on hover, then I don't think you would be able to mouse over the comment itself to click on links in the popover or its header.

pwendell commented 10 years ago

Oh I see - yeah I guess this would be more complicated, you'd need to pop it open on hover and then keep it open until the mouse has moved off of the comment.

On Fri, Aug 29, 2014 at 11:13 AM, Josh Rosen notifications@github.com wrote:

@pwendell https://github.com/pwendell If it displayed on hover, then I don't think you would be able to mouse over the comment itself to click on links in the popover or its header.

Reply to this email directly or view it on GitHub https://github.com/databricks/spark-pr-dashboard/issues/6#issuecomment-53911516 .

JoshRosen commented 10 years ago

See also: the usability issues that crop up with hover menus: a user might hover to open the popover, then drag their mouse diagonally to reach its contents. Usually, this causes the menu to close because the mouse temporarily leaves the hover target en-route to the popover / menu.

JoshRosen commented 10 years ago

Alright, I'm going to merge this so that other people can hack on it.