databricks / spark-pr-dashboard

Dashboard to aid in Spark pull request reviews
spark-prs.appspot.com
Apache License 2.0
54 stars 46 forks source link

Replace hard-coded Spark settings with config variables #61

Closed mxm closed 9 years ago

mxm commented 9 years ago

While playing around with the spark-pr-dashboard, I discovered that the variables in the settings file are not always respected. That led to a pretty nasty outcome :) Now, I would like to fix this such that other people, who blindly run the dashboard don't experience anything similar.

Other than that, kudos to everyone who helped putting this together. It's a nice piece of software.

JoshRosen commented 9 years ago

Thanks for working on this. I've tested out these changes and they worked fine, so I've merged this. Note that there are likely other parts of this project that are highly Spark-specific, so additional changes will likely be necessary if you want to use all of this tool's features with non-Spark projects.

mxm commented 9 years ago

Thanks for merging this! I realized that the Jenkins and QA bot integration is still Spark specific but I wanted the basic functionality to work independently of the project first. I might open a follow-up pull request. In the meantime, thanks for getting back to me so quickly.