databricks / spark-pr-dashboard

Dashboard to aid in Spark pull request reviews
spark-prs.appspot.com
Apache License 2.0
54 stars 46 forks source link

Fix corner-case in deletion of old AmplabJenkins comments #63

Closed JoshRosen closed 8 years ago

JoshRosen commented 8 years ago

This patch fixes a corner-case which was causing a PR comment updating task to consistently fail. It looks like the problem was a PR that contained only comments from AmplabJenkins which weren't categorized by our regexes could lead to pr.last_jenkins_comment being None even though the PR contained AmplabJenkins comments. The simple fix here is to just skip deletion of AmplabJenkins comments when we encounter this rare scenario.