search

databricks / spark-pr-dashboard

Dashboard to aid in Spark pull request reviews
spark-prs.appspot.com
Apache License 2.0
54 stars 46 forks source link

Can't install library dependencies via npm #69

Closed dragos closed 8 years ago

dragos commented 8 years ago

It looks like brix/grunt-jsxcs disappeared.

 $ npm install .
npm WARN deprecated react-tools@0.13.3: react-tools is deprecated. For more information, visit https://fb.me/react-tools-deprecated
npm ERR! git clone --template=/Users/dragos/.npm/_git-remotes/_templates --mirror git://github.com/brix/grunt-jsxcs.git /Users/dragos/.npm/_git-remotes/git-github-com-brix-grunt-jsxcs-git-4a077004: Cloning into bare repository '/Users/dragos/.npm/_git-remotes/git-github-com-brix-grunt-jsxcs-git-4a077004'...
npm ERR! git clone --template=/Users/dragos/.npm/_git-remotes/_templates --mirror git://github.com/brix/grunt-jsxcs.git /Users/dragos/.npm/_git-remotes/git-github-com-brix-grunt-jsxcs-git-4a077004: fatal: remote error: 
npm ERR! git clone --template=/Users/dragos/.npm/_git-remotes/_templates --mirror git://github.com/brix/grunt-jsxcs.git /Users/dragos/.npm/_git-remotes/git-github-com-brix-grunt-jsxcs-git-4a077004:   Repository not found.
npm ERR! Darwin 15.4.0
npm ERR! argv "node" "/usr/local/bin/npm" "install" "."
npm ERR! node v0.12.7
npm ERR! npm  v2.12.1
npm ERR! code 128

npm ERR! Command failed: git clone --template=/Users/dragos/.npm/_git-remotes/_templates --mirror git://github.com/brix/grunt-jsxcs.git /Users/dragos/.npm/_git-remotes/git-github-com-brix-grunt-jsxcs-git-4a077004
npm ERR! Cloning into bare repository '/Users/dragos/.npm/_git-remotes/git-github-com-brix-grunt-jsxcs-git-4a077004'...
npm ERR! fatal: remote error: 
npm ERR!   Repository not found.
npm ERR! 
npm ERR! 
npm ERR! If you need help, you may report this error at:
npm ERR!     <https://github.com/npm/npm/issues>

npm ERR! Please include the following file with any support request:
npm ERR!     /Users/dragos/workspace/Spark/spark-pr-dashboard/npm-debug.log
nchammas commented 8 years ago

Looks like the build has been broken since January 28 due to this issue.

nchammas commented 8 years ago

Maybe the package got moved here?

dragos commented 8 years ago

I think those are different packages. One is for jsx, the React.js dialect of XML, vs. jscs which is a stye checker for Javascript. I may be wrong though, I'm new to the js ecosystem.

nchammas commented 8 years ago

Oh sorry, you're right.

ajbozarth commented 8 years ago

I looked at this a few month ago when I checked out the code to play with and couldn't find any evidence of brix/grunt-jsxcs available, it seems it was just deleted and not replaced.

Based on some quick research just now though it seems that jscs added jsx support, so we should be able to switch.

JoshRosen commented 8 years ago

I don't have time to fix this myself but will be happy to review any pull requests that port the build to newer JS tools.