databricks / spark-pr-dashboard

Dashboard to aid in Spark pull request reviews
spark-prs.appspot.com
Apache License 2.0
54 stars 46 forks source link

Switched from grunt-jsxcs to grunt-jscs #70

Closed ajbozarth closed 8 years ago

ajbozarth commented 8 years ago

Switched from grunt-jsxcs to grunt-jscs since the former has been deleted and the latter now supports jsx files. This fixes #69

JoshRosen commented 8 years ago

Seems like a good approach, but I think we'll have to update our style checker configurations because it's currently failing checks.

ajbozarth commented 8 years ago

Yeah I saw right before I left work, I'll look into updating the configs tomorrow

ajbozarth commented 8 years ago

Updated configs to match new style checker guidelines

JoshRosen commented 8 years ago

LGTM. Thanks @ajbozarth!