search

databricks / spark-pr-dashboard

Dashboard to aid in Spark pull request reviews
spark-prs.appspot.com
Apache License 2.0
54 stars 46 forks source link

Remove PRs that no longer exist #72

Closed shivaram closed 8 years ago

shivaram commented 8 years ago

There are some PRs which no longer exist on github but are shown in the PR dashboard UI. A simple one is in the EC2 tab of the live site right now. It shows a link to https://github.com/apache/spark/pull/12690 for me but that link itself throws a 404.

shivaram commented 8 years ago

Here is a screenshot of what I see FWIW

screenshot 2016-06-15 15 48 52
ajbozarth commented 8 years ago

@JoshRosen from my look at the code there doesn't exist a check for if a pr was deleted, so any deleted prs would become zombies on the dash. Or is this hidden somewhere and missing some deleted prs?

ajbozarth commented 8 years ago

Also from a quick look, that specific PR seems unique in this zombie state

JoshRosen commented 8 years ago

Fixed by #73.