search

databricks / spark-pr-dashboard

Dashboard to aid in Spark pull request reviews
spark-prs.appspot.com
Apache License 2.0
54 stars 46 forks source link

Fixed word wrap so table is not wider than page #79

Closed ajbozarth closed 7 years ago

ajbozarth commented 7 years ago

Updated the css so pr titles will wrap mid-word if a word is so long it would make the table wider than the page. It only wraps on long words and only the title column is affected (long usernames aren't wrapped).

Tested on Latest Safari, Chrome and FirefoxESR

Before and after screenshots of the pr title that was causing the issue currently:

screen shot 2016-11-04 at 2 31 24 pm screen shot 2016-11-04 at 2 30 09 pm
ajbozarth commented 7 years ago

@JoshRosen here's a fix for the issue I found after #78 It was a quick fix

JoshRosen commented 7 years ago

Do you think that we should set a minimum width on the title cell? I've noticed that it can look really funny if you make the window small enough:

image

ajbozarth commented 7 years ago

I'll look into that, it might be that leaving it 'as is' is the better course of action in the end.

ajbozarth commented 7 years ago

I added a fix but while testing I realized that none of my fix works on Firefox like I thought, I'm not sure why I thought it did before. So if we want a fix for Safari and Chrome and left it a little off for FF (and IE/Edge?) this will work. Otherwise I say leave it as is for all of them.

ajbozarth commented 7 years ago

@JoshRosen just checking in in case you missed my update

ajbozarth commented 7 years ago

@JoshRosen just checking in since the site is still using my old code

JoshRosen commented 7 years ago

Just updated the site to use this PR's updated code. This looks good to me, so I'm going to merge this PR now. Thanks for fixing this!