search

databricks / spark-pr-dashboard

Dashboard to aid in Spark pull request reviews
spark-prs.appspot.com
Apache License 2.0
54 stars 46 forks source link

Don't require brackets around JIRA issue key #9

Closed nchammas closed 10 years ago

nchammas commented 10 years ago

Current matching behavior misses JIRA issue keys in titles that don't have brackets, like in this issue.

JoshRosen commented 10 years ago

Good idea, although I don't know how well this will work with the current code, which links the JIRA as it appears in the title. Maybe it would be better to identify the JIRAs, display them in a separate column, and find-and-replace to remove the JIRA tags from the issue title.

nchammas commented 10 years ago

Makes sense to me. Shall I close this for now and revisit when we go about making a new column specific to JIRA links?

JoshRosen commented 10 years ago

I'll try to address the JIRA column later tonight, so let's close this for now. Thanks for the reminder to fix this, though!

JoshRosen commented 10 years ago

Just pushed a change that displays the JIRAs in their own column. I also included some code to strip off portions of the "metadata" at the start of the issue title if they were redundant w.r.t. the other UI elements:

image

nchammas commented 10 years ago

Nice work! The extra column and stripped down titles make things quite a bit cleaner.