[ML-3342] Bug fixes to make mllib benchmarks work with dbr-4.0.

databricks / spark-sql-perf

Apache License 2.0

586 stars 407 forks source link

[ML-3342] Bug fixes to make mllib benchmarks work with dbr-4.0. #125

Closed MrBago closed 6 years ago

MrBago commented 6 years ago

In spark 2.3 some default param values were moved from Models to matching Estimators. I added explicit sets for these values in our tests to avoid errors. Also renamed ModelBuilder to ModelBuildersSSP to avoid a name conflict with dbml-local which is included in databricks runtime.

juliuszsompolski commented 6 years ago

cc @npoggi

smurching commented 6 years ago

Given the discussion above I think this PR is good as is, thanks @MrBago!

jkbradley commented 6 years ago

LGTM too. ~@juliuszsompolski or @npoggi do you want to vet all spark-sql-perf PRs, or do you mind if I merge ones for ML?~ Actually I realized that I asked that before. I'll merge it now. Thanks @MrBago and @smurching !