databricks / spark-sql-perf

Apache License 2.0
586 stars 407 forks source link

Additional method test for some ML algos #139

Closed WeichenXu123 closed 6 years ago

WeichenXu123 commented 6 years ago

Add additional method test for some ML algos.

In this PR, I add associationRules in FPGrowth and findSynonyms. After the design is accepted, I will add other methods later.

Add an interface in BenchmarkableAlgorithm:

  def testAdditionalMethods(ctx: MLBenchContext, model: Transformer): Map[String, () => _]
lu-wang-dl commented 6 years ago

I have run the test manually. Everything is clean.

jkbradley commented 6 years ago

LGTM The tests worked when run locally. Thanks @WeichenXu123 ! Merging with master